-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(calendar): Enhance accessibility by adding visually hidden text … #940
Merged
buseselvi
merged 6 commits into
Trendyol:next
from
mryunt02:feature/a11y-calendar-buttons
Oct 21, 2024
Merged
feat(calendar): Enhance accessibility by adding visually hidden text … #940
buseselvi
merged 6 commits into
Trendyol:next
from
mryunt02:feature/a11y-calendar-buttons
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to navigation buttons
buseselvi
requested review from
AykutSarac,
erbilnas,
fatihhayri and
dilandoogan
October 17, 2024 11:22
erbilnas
requested changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this finding about accessibility 🙏 Setting the label
attribute for bl-button works simply fine—no need to add an extra class. Example: Icon-Only Buttons
erbilnas
reviewed
Oct 17, 2024
Also, if you could apply the same for other buttons, we’d really appreciate it! 🧡 |
erbilnas
previously approved these changes
Oct 17, 2024
erbilnas
reviewed
Oct 18, 2024
erbilnas
approved these changes
Oct 18, 2024
AykutSarac
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
<span class="visually-hidden">Previous Calendar View</span>
was added to the previous button.<span class="visually-hidden">Next Calendar View</span>
was added to the next button.CSS
Related Issue
Fixes #939