Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove empty catch block #298

Merged
merged 1 commit into from
Sep 10, 2024
Merged

refactor: remove empty catch block #298

merged 1 commit into from
Sep 10, 2024

Conversation

mastudillot
Copy link
Member

This PR remove empty catch block in HttpClient class

Test

image image

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mvarlic
mvarlic approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@mvarlic mvarlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@mastudillot mastudillot merged commit c7ee7aa into develop Sep 10, 2024
2 checks passed
@mastudillot mastudillot deleted the refactor/delete-empty-catch-block branch September 10, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoHBustamante DiegoHBustamante DiegoHBustamante approved these changes

@mvarlic mvarlic mvarlic approved these changes

@victormendoza96 victormendoza96 Awaiting requested review from victormendoza96

@Matiasnickolas Matiasnickolas Awaiting requested review from Matiasnickolas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mastudillot @mvarlic @DiegoHBustamante