Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve status response #291

Merged
merged 2 commits into from
Sep 3, 2024
Merged

feat: improve status response #291

merged 2 commits into from
Sep 3, 2024

Conversation

Matiasnickolas
Copy link
Contributor

This PR improve status response when card number is null

image

image

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
62.2% Coverage on New Code (required ≥ 80%)
11.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

mastudillot
mastudillot approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@mastudillot mastudillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 🤙🏼

@Matiasnickolas Matiasnickolas merged commit fc30d67 into develop Sep 3, 2024
1 of 2 checks passed
@Matiasnickolas Matiasnickolas deleted the feat/improve-status-response branch September 3, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoHBustamante DiegoHBustamante DiegoHBustamante approved these changes

@mastudillot mastudillot mastudillot approved these changes

@mvarlic mvarlic Awaiting requested review from mvarlic

@victormendoza96 victormendoza96 Awaiting requested review from victormendoza96

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Matiasnickolas @mastudillot @DiegoHBustamante