Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade minimum php version #285

Merged
merged 51 commits into from
Jul 3, 2024
Merged

feat: upgrade minimum php version #285

merged 51 commits into from
Jul 3, 2024

Conversation

gasspper
Copy link

@gasspper gasspper commented Jul 1, 2024 •
edited
Loading

  • the minimum version of php was raised to 8.2
  • all variables were typed in the sdk

The tests will be updated in another PR, it will be attached here as soon as it is uploaded
The tests are corrected in the following PR: #286
image

gasspper added 17 commits June 19, 2024 10:49
@gasspper
chore: drop support for php under 8.2
cf443a0
@gasspper
docs: update readme with new version of php
e691190
@gasspper
feat: variables are typed
8e922bd
@gasspper
refactor: functions are improved to make it more readable
072260b
@gasspper
feat: typed default message
98ec3c1
@gasspper
refactor: add type in contracts files
54fa7d3
@gasspper
refactor: add type in patpass comercio files
997f409
@gasspper
refactor: add type in patpass comercio responses files
fbd0937
@gasspper
refactor: add type in utils files
e530862
@gasspper
refactor: add type in webpay files
a4d8352
@gasspper
refactor: add type in webpay exceptions files
c91df70
@gasspper
refactor: add type in oneclick files
e166427
@gasspper
refactor: add type in oneclick responses files
09afc76
@gasspper
refactor: add type in transaccion completa files
0b5d995
@gasspper
refactor: add type in transaccion completa responses files
cfa576c
@gasspper
refactor: add type in webpay plus files
d40fb2e
@gasspper
refactor: add type in webpay plus responses files
ce8637e
@gasspper gasspper self-assigned this Jul 1, 2024
@gasspper gasspper mentioned this pull request Jul 2, 2024
Merged
@gasspper gasspper requested a review from mastudillot July 2, 2024 22:00
gasspper added 17 commits July 3, 2024 11:38
@gasspper
refactor: add return type in build function for inscription class
53c40a1
@gasspper
refactor: delete unnecesary patpass comerce props
65fbd24
@gasspper
refactor: change nullable string type by union types
74c02f9
@gasspper
refactor: change nullable array type by union types
7c3ff89
@gasspper
refactor: change nullable int type by union types
00f7f54
@gasspper
refactor: change nullable float type by union types
0f2574a
@gasspper
refactor: change nullable ResponseInterface type by union types
f80f1c3
@gasspper
refactor: change nullable TransbankApiRequest type by union types
8f37497
@gasspper
refactor: change nullable HttpClientInterface type by union types
ea6048a
@gasspper
refactor: change nullable RequestService type by union types
56fd2ce
@gasspper
refactor: change nullable Throwable type by union types
e018657
@gasspper
refactor: change nullable Exception type by union types
a3d1069
@gasspper
refactor: change nullable bool type by union types
9d7ae69
@gasspper
refactor: change nullable TransactionDetail type by union types
4996225
@gasspper
refactor: change int type to float in prepaid balance
c2e581f
@gasspper
refactor: change int type by string in docphp for webpayplus transact…
bbaa77a 
…ion detail
@gasspper
refactor: change casting type for captureAmount
e785b00
Matiasnickolas
Matiasnickolas approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@Matiasnickolas Matiasnickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤙

@gasspper gasspper requested a review from Matiasnickolas July 3, 2024 21:05
tribiec
tribiec approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@tribiec tribiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 🚀

@gasspper gasspper requested a review from tribiec July 3, 2024 21:19
Matiasnickolas
Matiasnickolas approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@Matiasnickolas Matiasnickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌝

@gasspper gasspper merged commit e15926a into develop Jul 3, 2024
1 check failed
@gasspper gasspper deleted the feat/upgrade-minimum-php-version branch July 3, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matiasnickolas Matiasnickolas Matiasnickolas approved these changes

@tribiec tribiec tribiec approved these changes

@victormendoza96 victormendoza96 Awaiting requested review from victormendoza96

@DiegoHBustamante DiegoHBustamante Awaiting requested review from DiegoHBustamante

@mastudillot mastudillot Awaiting requested review from mastudillot

Assignees

@gasspper gasspper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gasspper @tribiec @mastudillot @Matiasnickolas