Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set request timeout #282

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Conversation

Matiasnickolas
Copy link
Contributor

This PR add a default timeout for requests on 10 minutes.
This can configured using an Options object when creating the products. The fourth parameter is a value in seconds , for example:

$timeOut = 20;
$options = new Options("commerceCode", "apiKey", Options::ENVIRONMENT_INTEGRATION, $timeOut);
$transaction = new Transaction($options);

TEST

image

image

image

image

Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
61.4% Coverage on New Code (required ≥ 80%)
12.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Matiasnickolas Matiasnickolas merged commit 6c00374 into develop Jun 6, 2024
1 of 2 checks passed
@Matiasnickolas Matiasnickolas deleted the feat/set-request-timeout branch June 6, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants