Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecesary code #279

Merged
merged 26 commits into from
Apr 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
27babea
refactor: remove unused common response class
Matiasnickolas Apr 25, 2024
add4fac
refactor: remove unused setters on webpay plus responses
Matiasnickolas Apr 25, 2024
a999648
refactor: use status enum instead const
Matiasnickolas Apr 29, 2024
5b2f7a0
refactor: remove unused setters on webpay plus refund response
Matiasnickolas Apr 29, 2024
b96fd64
refactor: remove unused oneclick trait
Matiasnickolas Apr 29, 2024
167fd9b
refactor: remove unused methods on oneclick responses
Matiasnickolas Apr 29, 2024
3e24411
refactor: remove unused setters on complete transaction responses
Matiasnickolas Apr 29, 2024
3f7e2f7
refactor: remove unused setters on Patpass comercio responses
Matiasnickolas Apr 29, 2024
3d5a6e5
refactor: remove unused setters on Patpass by webpay responses
Matiasnickolas Apr 29, 2024
be6b3ed
test: fix oneclick mall transaction capture tests
Matiasnickolas Apr 30, 2024
405aabe
test: fix oneclick inscription finish response test
Matiasnickolas Apr 30, 2024
e00b163
test: fix transaction status response test on complete transaction
Matiasnickolas Apr 30, 2024
23b3c9f
test: fix transaction refund response test on complete transaction
Matiasnickolas Apr 30, 2024
39bbab7
test: fix installments response test on complete transaction
Matiasnickolas Apr 30, 2024
dab870b
fix: transaction detail test response on complete transaction
Matiasnickolas Apr 30, 2024
4244f25
test: fix transaction create response test on complete transaction
Matiasnickolas Apr 30, 2024
3c57db2
test: fix mall transaction refund response test on complete transaction
Matiasnickolas Apr 30, 2024
83f763a
test: fix mall transaction installments test on complete transaction
Matiasnickolas Apr 30, 2024
0414962
test: fix mall transaction create test on complete transaction
Matiasnickolas Apr 30, 2024
d206dee
test: fix inscription status response test on patpass comercio
Matiasnickolas Apr 30, 2024
b4e815c
test: fix inscription start response test on patpass comercio
Matiasnickolas Apr 30, 2024
132cdc9
test: fix inscription finish response test on patpass comercio
Matiasnickolas Apr 30, 2024
2f7ebc4
test: fix transaction create response test on patpass by wepay
Matiasnickolas Apr 30, 2024
5833df3
test: fix transaction commit response test on patpass by webpay
Matiasnickolas Apr 30, 2024
494d6ad
refactor: remove unused setters on HasTransactionStatus
Matiasnickolas Apr 30, 2024
35ecf98
test: fix has transaction status test
Matiasnickolas Apr 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 0 additions & 58 deletions src/Common/Responses/BaseDeferredStatusResponse.php

This file was deleted.

143 changes: 0 additions & 143 deletions src/Patpass/PatpassByWebpay/Responses/TransactionCommitResponse.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,18 +46,6 @@ public function getVci()
return $this->vci;
}

/**
* @param mixed $vci
*
* @return TransactionCommitResponse
*/
public function setVci($vci)
{
$this->vci = $vci;

return $this;
}

/**
* @return mixed
*/
Expand All @@ -66,18 +54,6 @@ public function getAmount()
return $this->amount;
}

/**
* @param mixed $amount
*
* @return TransactionCommitResponse
*/
public function setAmount($amount)
{
$this->amount = $amount;

return $this;
}

/**
* @return mixed
*/
Expand All @@ -86,18 +62,6 @@ public function getStatus()
return $this->status;
}

/**
* @param mixed $status
*
* @return TransactionCommitResponse
*/
public function setStatus($status)
{
$this->status = $status;

return $this;
}

/**
* @return mixed
*/
Expand All @@ -106,18 +70,6 @@ public function getBuyOrder()
return $this->buyOrder;
}

/**
* @param mixed $buyOrder
*
* @return TransactionCommitResponse
*/
public function setBuyOrder($buyOrder)
{
$this->buyOrder = $buyOrder;

return $this;
}

/**
* @return mixed
*/
Expand All @@ -126,18 +78,6 @@ public function getSessionId()
return $this->sessionId;
}

/**
* @param mixed $sessionId
*
* @return TransactionCommitResponse
*/
public function setSessionId($sessionId)
{
$this->sessionId = $sessionId;

return $this;
}

/**
* @return mixed
*/
Expand All @@ -146,18 +86,6 @@ public function getCardDetail()
return $this->cardDetail;
}

/**
* @param mixed $cardNumber
*
* @return TransactionCommitResponse
*/
public function setCardDetail($cardDetail)
{
$this->cardDetail = $cardDetail;

return $this;
}

/**
* @return mixed
*/
Expand All @@ -166,18 +94,6 @@ public function getAccountingDate()
return $this->accountingDate;
}

/**
* @param mixed $accountingDate
*
* @return TransactionCommitResponse
*/
public function setAccountingDate($accountingDate)
{
$this->accountingDate = $accountingDate;

return $this;
}

/**
* @return mixed
*/
Expand All @@ -186,18 +102,6 @@ public function getTransactionDate()
return $this->transactionDate;
}

/**
* @param mixed $transactionDate
*
* @return TransactionCommitResponse
*/
public function setTransactionDate($transactionDate)
{
$this->transactionDate = $transactionDate;

return $this;
}

/**
* @return mixed
*/
Expand All @@ -206,18 +110,6 @@ public function getAuthorizationCode()
return $this->authorizationCode;
}

/**
* @param mixed $authorizationCode
*
* @return TransactionCommitResponse
*/
public function setAuthorizationCode($authorizationCode)
{
$this->authorizationCode = $authorizationCode;

return $this;
}

/**
* @return mixed
*/
Expand All @@ -226,18 +118,6 @@ public function getPaymentTypeCode()
return $this->paymentTypeCode;
}

/**
* @param mixed $paymentTypeCode
*
* @return TransactionCommitResponse
*/
public function setPaymentTypeCode($paymentTypeCode)
{
$this->paymentTypeCode = $paymentTypeCode;

return $this;
}

/**
* @return mixed
*/
Expand All @@ -246,18 +126,6 @@ public function getResponseCode()
return (int) $this->responseCode;
}

/**
* @param mixed $responseCode
*
* @return TransactionCommitResponse
*/
public function setResponseCode($responseCode)
{
$this->responseCode = $responseCode;

return $this;
}

/**
* @return mixed
*/
Expand All @@ -266,15 +134,4 @@ public function getInstallmentsNumber()
return $this->installmentsNumber;
}

/**
* @param mixed $installmentsNumber
*
* @return TransactionCommitResponse
*/
public function setInstallmentsNumber($installmentsNumber)
{
$this->installmentsNumber = $installmentsNumber;

return $this;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,6 @@ public function getToken()
return $this->token;
}

/**
* @param mixed $token
*
* @return TransactionCreateResponse
*/
public function setToken($token)
{
$this->token = $token;

return $this;
}

/**
* @return mixed
*/
Expand All @@ -48,15 +36,4 @@ public function getUrl()
return $this->url;
}

/**
* @param mixed $url
*
* @return TransactionCreateResponse
*/
public function setUrl($url)
{
$this->url = $url;

return $this;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,6 @@ public function getStatus()
return $this->status;
}

/**
* @param mixed $status
*/
public function setStatus($status)
{
$this->status = $status;

return $this;
}

/**
* @return mixed
*/
Expand All @@ -51,13 +41,4 @@ public function getCode()
return $this->code;
}

/**
* @param mixed $code
*/
public function setCode($code)
{
$this->code = $code;

return $this;
}
}
23 changes: 0 additions & 23 deletions src/Patpass/PatpassComercio/Responses/InscriptionStartResponse.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,6 @@ public function getToken()
return $this->token;
}

/**
* @param mixed $token
*
* @return InscriptionStartResponse
*/
public function setToken($token)
{
$this->token = $token;

return $this;
}

/**
* @return mixed
*/
Expand All @@ -54,15 +42,4 @@ public function getUrlWebpay()
return $this->urlWebpay;
}

/**
* @param mixed $url
*
* @return InscriptionStartResponse
*/
public function setUrlWebpay($url)
{
$this->urlWebpay = $url;

return $this;
}
}
Loading
Loading