Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix config file #278

Merged
merged 2 commits into from
Apr 25, 2024
Merged

test: fix config file #278

merged 2 commits into from
Apr 25, 2024

Conversation

Matiasnickolas
Copy link
Contributor

This PR removes an unused element on config file that triggered an alert during test execution.

Before:

image

Now:

image

@Matiasnickolas Matiasnickolas self-assigned this Apr 24, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
12.5% Coverage on New Code (required ≥ 80%)
14.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

mastudillot
mastudillot approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@mastudillot mastudillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matiasnickolas Matiasnickolas merged commit 57c9d47 into develop Apr 25, 2024
1 of 2 checks passed
@Matiasnickolas Matiasnickolas deleted the test/fix-config-file branch April 25, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastudillot mastudillot mastudillot approved these changes

@tribiec tribiec tribiec approved these changes

@isabellaahc isabellaahc Awaiting requested review from isabellaahc

Assignees

@Matiasnickolas Matiasnickolas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Matiasnickolas @tribiec @mastudillot