Merge pull request #302 from TransbankDevelopers/feat/improve-delete-…

…method feat: improve delete method
TransbankDevelopers · Oct 7, 2024 · f1035a3 · f1035a3
2 parents f0cdcae + 8606aea
commit f1035a3
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 75 deletions.
diff --git a/src/Webpay/Oneclick/MallInscription.php b/src/Webpay/Oneclick/MallInscription.php
@@ -7,7 +7,6 @@
 use Transbank\Webpay\Oneclick\Exceptions\InscriptionDeleteException;
 use Transbank\Webpay\Oneclick\Exceptions\InscriptionFinishException;
 use Transbank\Webpay\Oneclick\Exceptions\InscriptionStartException;
-use Transbank\Webpay\Oneclick\Responses\InscriptionDeleteResponse;
 use Transbank\Webpay\Oneclick\Responses\InscriptionFinishResponse;
 use Transbank\Webpay\Oneclick\Responses\InscriptionStartResponse;
 
@@ -89,14 +88,13 @@ public function finish(string $token): InscriptionFinishResponse
      * @param string $tbkUser
      * @param string $username
      *
-     * @return InscriptionDeleteResponse
+     * @return bool
      *
      * @throws InscriptionDeleteException
      * @throws \Transbank\Utils\Curl\Exceptions\CurlRequestException
      */
-    public function delete(string $tbkUser, string $username): InscriptionDeleteResponse
+    public function delete(string $tbkUser, string $username): bool
     {
-        $successDeletedCode = 204;
         $payload = [
             'tbk_user' => $tbkUser,
             'username' => $username,
@@ -109,9 +107,6 @@ public function delete(string $tbkUser, string $username): InscriptionDeleteResp
                 $payload
             );
         } catch (WebpayRequestException $exception) {
-            if ($exception->getHttpCode() !== $successDeletedCode) {
-                return new InscriptionDeleteResponse(false, $exception->getHttpCode());
-            }
 
             throw new InscriptionDeleteException(
                 $exception->getMessage(),
@@ -122,6 +117,6 @@ public function delete(string $tbkUser, string $username): InscriptionDeleteResp
             );
         }
 
-        return new InscriptionDeleteResponse(true, $successDeletedCode);
+        return true;
     }
 }
diff --git a/src/Webpay/Oneclick/Responses/InscriptionDeleteResponse.php b/src/Webpay/Oneclick/Responses/InscriptionDeleteResponse.php
diff --git a/tests/Webpay/OneClick/Responses/InscriptionDeleteResponseTest.php b/tests/Webpay/OneClick/Responses/InscriptionDeleteResponseTest.php
diff --git a/tests/Webpay/OneClick/TransbankOneclickTest.php b/tests/Webpay/OneClick/TransbankOneclickTest.php
@@ -265,8 +265,7 @@ public function it_deletes_an_existing_inscription()
         $inscription = new MallInscription($options, $requestServiceMock);
         $deleteResponse = $inscription->delete('tbkTestUser', 'useNameTest');
 
-        $this->assertTrue($deleteResponse->wasSuccessfull());
-        $this->assertSame(204, $deleteResponse->getCode());
+        $this->assertTrue($deleteResponse);
     }
 
     /** @test */
@@ -279,10 +278,8 @@ public function it_deletes_an_unexisting_inscription()
             ->willThrowException(new WebpayRequestException("Could not obtain a response from Transbank API", null, 404));
         $options = new Options('apiKey', 'commerceCode', Options::ENVIRONMENT_INTEGRATION);
         $inscription = new MallInscription($options, $requestServiceMock);
-        $deleteResponse = $inscription->delete('tbkTestUser', 'useNameTest');
-
-        $this->assertFalse($deleteResponse->wasSuccessfull());
-        $this->assertSame(404, $deleteResponse->getCode());
+        $this->expectException(InscriptionDeleteException::class);
+        $inscription->delete('tbkTestUser', 'useNameTest');
     }
 
     /** @test */