Skip to content

Commit

Permalink
Merge pull request #36 from TransbankDevelopers/fix/options-get-defaults
Browse files Browse the repository at this point in the history
Prepare release 1.3.1
  • Loading branch information
goncafa authored Sep 11, 2018
2 parents 78b60f2 + 9fd98bd commit e23af09
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ Todos los cambios notables a este proyecto serán docuemntados en este archivo.
El formato está basado en [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
y este proyecto adhiere a [Semantic Versioning](http://semver.org/spec/v2.0.0.html).


## [1.3.1] - 2018-09-11
### Fixed
- `OnepayRequestBuilder::buildOptions` no setea el appKey correcto en caso que se entregue como base
un `options` nulo. Se corrige este error seteando en el constructor de `options` el appKey
correcto en vez de dejarlo null.

## [1.3.0] - 2018-09-10
### Added
- Configuración de las credenciales de integración por defecto. Ya no será necesario que
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ automaticamente, pero si usas el SDK de manera directa requerirás también:
Para usar el SDK en tu proyecto puedes usar Composer, añadiendo el SDK como dependencia a tu proyecto:
```json
"require": {
"transbank/transbank-sdk": "1.3.0"
"transbank/transbank-sdk": "1.3.1"
}
```

Expand Down
5 changes: 1 addition & 4 deletions lib/Options.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,7 @@ public function __construct($apiKey = null, $sharedSecret = null)
{
$this->setApiKey($apiKey);
$this->setSharedSecret($sharedSecret);
// If app key is null then OnepayRequestBuilder will use
// OnepayBase::getCurrentIntegrationTypeAppKey() which
// is a pretty good default:
$this->setAppKey(null);
$this->setAppKey(OnepayBase::getCurrentIntegrationTypeAppKey());
}

public function jsonSerialize()
Expand Down

0 comments on commit e23af09

Please sign in to comment.