Merge pull request #290 from TransbankDevelopers/feat/improve-oneclic…

…k-delete-response

feat: improve oneclick delete response

src/Utils/HttpClientRequestService.php

@@ -94,7 +94,7 @@ public function request(
             throw new WebpayRequestException($message, $tbkErrorMessage, $responseStatusCode, $request);
         }
 
-        return json_decode($response->getBody(), true);
+        return json_decode($response->getBody(), true) ?? [];
     }
 
     /**

src/Webpay/Oneclick/MallInscription.php

@@ -97,6 +97,7 @@ public function finish(string $token): InscriptionFinishResponse
      */
     public function delete(string $tbkUser, string $username): InscriptionDeleteResponse
     {
+        $successDeletedCode = 204;
         $payload = [
             'tbk_user' => $tbkUser,
             'username' => $username,
@@ -109,7 +110,7 @@ public function delete(string $tbkUser, string $username): InscriptionDeleteResp
                 $payload
             );
         } catch (WebpayRequestException $exception) {
-            if ($exception->getHttpCode() !== 204) {
+            if ($exception->getHttpCode() !== $successDeletedCode) {
                 return new InscriptionDeleteResponse(false, $exception->getHttpCode());
             }
 
@@ -122,6 +123,6 @@ public function delete(string $tbkUser, string $username): InscriptionDeleteResp
             );
         }
 
-        return new InscriptionDeleteResponse(true);
+        return new InscriptionDeleteResponse(true, $successDeletedCode);
     }
 }

tests/RequestServiceTest.php

@@ -57,4 +57,17 @@ public function it_uses_the_base_url_provided_by_the_given_options()
             );
         (new HttpClientRequestService($httpClientMock))->request('POST', $endpoint, [], $optionsMock);
     }
+
+    /** @test */
+    public function it_returns_an_empty_array()
+    {
+        $options = new Options('ApiKey', 'commerceCode', Options::ENVIRONMENT_INTEGRATION);
+        $httpClientMock = $this->createMock(HttpClient::class);
+        $httpClientMock
+            ->expects($this->once())
+            ->method('request')
+            ->willReturn(new Response(204));
+        $response = (new HttpClientRequestService($httpClientMock))->request('DELETE', '/inscriptions', [], $options);
+        $this->assertSame([], $response);
+    }
 }

tests/Webpay/OneClick/TransbankOneclickTest.php

@@ -12,6 +12,8 @@
 use Transbank\Webpay\Oneclick\MallTransaction;
 use Transbank\Webpay\Oneclick\Responses\InscriptionFinishResponse;
 use Transbank\Webpay\Oneclick\Responses\InscriptionStartResponse;
+use Transbank\Utils\HttpClientRequestService;
+use Transbank\Webpay\Exceptions\WebpayRequestException;
 
 class TransbankOneclickTest extends TestCase
 {
@@ -241,4 +243,36 @@ public function it_configures_transaction_with_options()
         $this->assertSame(Options::ENVIRONMENT_PRODUCTION, $transactionOptions->getIntegrationType());
         $this->assertSame(Options::BASE_URL_PRODUCTION, $transactionOptions->getApiBaseUrl());
     }
+
+    /** @test */
+    public function it_deletes_an_existing_inscription()
+    {
+        $requestServiceMock = $this->createMock(HttpClientRequestService::class);
+        $requestServiceMock
+            ->expects($this->once())
+            ->method('request')
+            ->willReturn([]);
+        $options = new Options('apiKey', 'commerceCode', Options::ENVIRONMENT_INTEGRATION);
+        $inscription = new MallInscription($options, $requestServiceMock);
+        $deleteResponse = $inscription->delete('tbkTestUser', 'useNameTest');
+
+        $this->assertTrue($deleteResponse->wasSuccessfull());
+        $this->assertSame(204, $deleteResponse->getCode());
+    }
+
+    /** @test */
+    public function it_deletes_an_unexisting_inscription()
+    {
+        $requestServiceMock = $this->createMock(HttpClientRequestService::class);
+        $requestServiceMock
+            ->expects($this->once())
+            ->method('request')
+            ->willThrowException(new WebpayRequestException("Could not obtain a response from Transbank API", null, 404));
+        $options = new Options('apiKey', 'commerceCode', Options::ENVIRONMENT_INTEGRATION);
+        $inscription = new MallInscription($options, $requestServiceMock);
+        $deleteResponse = $inscription->delete('tbkTestUser', 'useNameTest');
+
+        $this->assertFalse($deleteResponse->wasSuccessfull());
+        $this->assertSame(404, $deleteResponse->getCode());
+    }
 }