Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sonar adjustments #185

Merged
merged 9 commits into from
Mar 22, 2024
Merged

refactor: sonar adjustments #185

merged 9 commits into from
Mar 22, 2024

Conversation

tribiec
Copy link
Contributor

@tribiec tribiec commented Mar 21, 2024

This PR covers some fixes required by Sonar in order to release the new version.

Copy link
Member

@mastudillot mastudillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use lombook to create seters and geters

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mastudillot mastudillot self-requested a review March 22, 2024 20:10
Copy link
Member

@mastudillot mastudillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tribiec tribiec merged commit 2fe1506 into develop Mar 22, 2024
7 checks passed
@tribiec tribiec deleted the refactor/sonar-adjustments branch March 22, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants