Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: double redirection protection in webpayplus #250

Merged
merged 21 commits into from
Aug 14, 2024

Conversation

gasspper
Copy link
Contributor

@gasspper gasspper commented Aug 9, 2024

Description

  • Added protection so that the checkout process always works the same way for the same order, despite unexpected redirects.
  • Refactoring of the code to make it more readable

PS: All Sonar comments are resolved in the following PR #251

Before

Captura de pantalla 2024-08-09 a la(s) 17 19 26
image

After

Captura de pantalla 2024-08-09 a la(s) 17 21 48

@mastudillot
Copy link
Member

Tests

Transaction Ok with classic Checkout

image

Transaction cancel by user with classic Checkout

image

Transaction Timeout with classic Checkout

image

Transaction error with classic Checkout

image

Transaction Ok with Block Checkout

image

Transaction cancel by user with Block Checkout

image

Transaction Timeout with Block Checkout

image

Transaction error with Block Checkout

image

Error in order already process

image
image

Copy link
Member

@mastudillot mastudillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comment

@gasspper gasspper requested a review from mastudillot August 13, 2024 15:45
Copy link
Member

@mastudillot mastudillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Contributor

@Matiasnickolas Matiasnickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 🚀

@gasspper gasspper merged commit acf66c5 into develop Aug 14, 2024
3 of 4 checks passed
@gasspper gasspper deleted the feat/double-redirection-protection branch August 14, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants