chore: add reserved column in line-colors for future use #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: The one with the braid <[email protected]>
marhei
added
the
needs-discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not data change but adding a new, empty column to the
line-data.csv. It can be used in future and is meant to avoid major conflicts when ever adding new columns to the dataset.In particular, you might have guessed, I'm adding this column with #263 in mind.
Since I don't see any major disadvantage in having one more column but see (eve aside of the mentioned PR) use cases in having a void placeholder for future extension, I'd appreciate to adjust the data format prior to discussing eventual acceptance of #263 .