Create a separate build for running the format tests #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrayHatter
force-pushed
the
formatting
branch
4 times, most recently
from
d65fc28 to
2ccaf86
Compare
|
Reviewed 6 of 6 files at r1. Comments from Reviewable |
|
This adds 1.5 minutes to the total build time. Can we put the formatting check at the beginning of the build (in addition to it being a test for the local use case)? That way, it'll terminate early with incorrect formatting. The real fix is this: TokTok/hs-github-tools#36 |
|
@iphydf I'm not sure what you're asking for here? can you enumerate the changes you want? |
|
|
Once you do that, rename the PR (and commit). |
iphydf
changed the title
iphydf
changed the title
|
Moved to #450. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is