cleanup: Align internal logger with external on type of source line. #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
changed the title
JFreegman
reviewed
Dec 29, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @iphydf)
other/DHT_bootstrap.c line 123 at r1 (raw file):
const char *func, const char *message, void *userdata) { fprintf(stderr, "[%s] %s:%d(%s) %s\n", strlevel(level), file, line, func, message);
Is is okay to format a uint32_t with %d?
github-actions
bot
added
the
cleanup
iphydf
commented
Jan 12, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @JFreegman)
other/DHT_bootstrap.c line 123 at r1 (raw file):
Previously, JFreegman wrote…
Is is okay to format a uint32_t with %d?
Ish, but yes it's cleaner to do %u. Done.
Green-Sky
approved these changes
Jan 12, 2025
iphydf
force-pushed
the
uint-line
branch
2 times, most recently
from
958d91e to
73be7d4
Compare
We use `uint32_t` everywhere now. It's easier that way, and line numbers are never negative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
uint32_teverywhere now. It's easier that way, and line numbers are never negative.This change is