Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use strong typedef for network family. #2641

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Feb 3, 2024

This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Feb 3, 2024
@iphydf iphydf marked this pull request as ready for review February 3, 2024 22:27
@iphydf iphydf requested a review from a team as a code owner February 3, 2024 22:28
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: Patch coverage is 67.16418% with 22 lines in your changes missing coverage. Please review.

Project coverage is 73.09%. Comparing base (0ec4978) to head (12cfaec).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
toxcore/network.c 63.93% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2641      +/-   ##
==========================================
- Coverage   73.09%   73.09%   -0.01%     
==========================================
  Files         149      149              
  Lines       30533    30559      +26     
==========================================
+ Hits        22319    22337      +18     
- Misses       8214     8222       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the bitwise-family branch 10 times, most recently from 132b8bd to 32b4edf Compare February 9, 2024 15:24
@iphydf iphydf modified the milestones: v0.2.19, v0.2.20 Feb 11, 2024
@iphydf iphydf marked this pull request as draft March 7, 2024 16:20
@iphydf iphydf modified the milestones: v0.2.20, v0.2.21 Nov 6, 2024
@github-actions github-actions bot added the refactor Refactoring production code, eg. renaming a variable, not affecting semantics label Nov 8, 2024
@iphydf iphydf modified the milestones: v0.2.21, v0.2.x Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring production code, eg. renaming a variable, not affecting semantics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant