refactor: Move pack/unpack IP_Port from DHT into network module.
#2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2612 +/- ##
==========================================
- Coverage 73.64% 73.61% -0.03%
==========================================
Files 148 148
Lines 30407 30407
==========================================
- Hits 22392 22385 -7
- Misses 8015 8022 +7 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
pack-unpack-ip
branch
from
ab4eeda to
ae65b33
Compare
robinlinden
approved these changes
Jan 30, 2024
It's misplaced in DHT, since the data structures are located in network.
iphydf
force-pushed
the
pack-unpack-ip
branch
from
ae65b33 to
1710a0d
Compare
nurupo
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
|
TokTok/hs-tokstyle#248 is needed for this PR, which triggered a bug in the cimple type checking algorithm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's misplaced in DHT, since the data structures are located in network.
This change is