refactor: Add mem module to allow tests to override allocators.
#2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
mem
branch
3 times, most recently
from
d194b00 to
f68de74
Compare
iphydf
changed the title
mem module to allow tests to override allocators. [WIP]mem module to allow tests to override allocators.
iphydf
force-pushed
the
mem
branch
9 times, most recently
from
ec51cce to
8062297
Compare
iphydf
force-pushed
the
mem
branch
2 times, most recently
from
eb51056 to
fe50f6c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2393 +/- ##
===========================================
+ Coverage 9.99% 74.49% +64.49%
===========================================
Files 141 87 -54
Lines 32530 26194 -6336
===========================================
+ Hits 3250 19512 +16262
+ Misses 29280 6682 -22598
☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
mem
branch
2 times, most recently
from
554e7cd to
bfb95ae
Compare
iphydf
force-pushed
the
mem
branch
2 times, most recently
from
51170fc to
5e7a651
Compare
iphydf
force-pushed
the
mem
branch
3 times, most recently
from
f4a6b4e to
6416aa7
Compare
iphydf
force-pushed
the
mem
branch
3 times, most recently
from
9c26abb to
ea5e1e3
Compare
robinlinden
requested changes
Aug 29, 2023
iphydf
force-pushed
the
mem
branch
7 times, most recently
from
944cc83 to
63dc3e4
Compare
robinlinden
approved these changes
Aug 30, 2023
This will allow us to do more interesting things with memory allocation within toxcore, and allow fuzzers to explore various allocation failure paths.
|
A bit confused by this PR and #2397 both introducing the mem module and using new system_{random,network,memory}. Is one PR build on top of another? Or perhaps these are alternative implementations of the same thing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to do more interesting things with memory allocation within toxcore, and allow fuzzers to explore various allocation failure paths.
This change is