-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: increase NGC lossy custom packet size #2384
Conversation
Why 1000? Why is lossless larger? |
|
quote from https://www.libtorrent.org/utp.html
|
4b09a44
to
8f353cd
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2384 +/- ##
==========================================
+ Coverage 71.52% 71.65% +0.12%
==========================================
Files 75 75
Lines 25195 25200 +5
==========================================
+ Hits 18020 18056 +36
+ Misses 7175 7144 -31 ☔ View full report in Codecov by Sentry. |
still same question why 1000 ? since tox already uses 1400 for everything else. Line 297 in 24b5472
Line 306 in 24b5472
Line 37 in 24b5472
c-toxcore/toxcore/net_crypto.h Line 80 in 24b5472
1000 (and also 500) does not make any sense |
Treat this pr as a proof of concept, until we decide how large exactly.
|
8f353cd
to
f3447c3
Compare
f3447c3
to
8cf3469
Compare
ca97d7b
to
919e946
Compare
fd7aad5
to
f2f4a3d
Compare
7b7c8fb
to
161e11f
Compare
4a356ec
to
fbe4832
Compare
a534f55
to
38d17b2
Compare
38d17b2
to
3909c07
Compare
3909c07
to
15ee46d
Compare
since toxcore places the responsibility to ensure the data does not get lost on the user (programmer), this can be seen as backwards compatible.
This change is