Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: port sports-league-scheduling quickstart example from Java to Python #685

Merged
merged 3 commits into from
Jan 16, 2025
Merged

chore: port sports-league-scheduling quickstart example from Java to Python #685

merged 3 commits into from
Jan 16, 2025

Conversation

PatrickDiallo23
Copy link

@PatrickDiallo23 PatrickDiallo23 commented Jan 15, 2025 •
edited by Christopher-Chianelli
Loading

Description of the change

Port the sports-league-scheduling quickstart example from Java to Python while keeping the same functionality.

Checklist

Development

  • The changes have been covered with tests, if necessary.
  • You have a green build, with the exception of the flaky tests.
  • UI and JS files are fully tested, the user interface works for all modules affected by your changes (e.g., solve and analyze buttons).
  • The network calls work for all modules affected by your changes (e.g., solving a problem).
  • The console messages are validated for all modules affected by your changes.

Code Review

  • This pull request includes an explanatory title and description.
  • The GitHub issue is linked.
  • At least one other engineer has approved the changes.
  • After PR is merged, inform the reporter.

@triceo
Copy link
Contributor

triceo commented Jan 15, 2025

Thanks for the contribution, @PatrickDiallo23!
We'll take a look when time permits.

Christopher-Chianelli
Christopher-Chianelli requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Christopher-Chianelli Christopher-Chianelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @PatrickDiallo23! I am impressed with the quality of the port. Some suggestions for improvement + consistency with the other quickstarts.

python/sports-league-scheduling/static/index.html Outdated Show resolved Hide resolved
python/sports-league-scheduling/src/sports_league_scheduling/constraints.py Outdated Show resolved Hide resolved
python/sports-league-scheduling/src/sports_league_scheduling/constraints.py Outdated Show resolved Hide resolved
python/sports-league-scheduling/src/sports_league_scheduling/demo_data.py Outdated Show resolved Hide resolved
python/sports-league-scheduling/src/sports_league_scheduling/demo_data.py Outdated Show resolved Hide resolved
python/sports-league-scheduling/src/sports_league_scheduling/domain.py Show resolved Hide resolved
python/sports-league-scheduling/src/sports_league_scheduling/domain.py Outdated Show resolved Hide resolved
python/sports-league-scheduling/src/sports_league_scheduling/domain.py Outdated Show resolved Hide resolved
python/sports-league-scheduling/tests/test_constraints.py Outdated Show resolved Hide resolved
python/sports-league-scheduling/tests/test_constraints.py Outdated Show resolved Hide resolved
@PatrickDiallo23
Copy link
Author

Hello @Christopher-Chianelli! I did another commit where I applied your code suggestions. Please review. Thank you!

Christopher-Chianelli
Christopher-Chianelli requested changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@Christopher-Chianelli Christopher-Chianelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mild formatting changes. It appears you missed the requested changes that were hidden by default (since GitHub automatically hides requested changes in the middle when there are many requests). Do the missed requested changes + the formatting ones, then it'll LGTM.

python/sports-league-scheduling/src/sports_league_scheduling/constraints.py Outdated Show resolved Hide resolved
python/sports-league-scheduling/src/sports_league_scheduling/constraints.py Outdated Show resolved Hide resolved
python/sports-league-scheduling/src/sports_league_scheduling/constraints.py Outdated Show resolved Hide resolved
python/sports-league-scheduling/src/sports_league_scheduling/constraints.py Outdated Show resolved Hide resolved
python/sports-league-scheduling/src/sports_league_scheduling/constraints.py Outdated Show resolved Hide resolved
@PatrickDiallo23
Copy link
Author

My bad! I have updated the example accordingly. Please let me know if everything is okay now.

Christopher-Chianelli
Christopher-Chianelli approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@Christopher-Chianelli Christopher-Chianelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when green

@Christopher-Chianelli Christopher-Chianelli merged commit 498596e into TimefoldAI:development Jan 16, 2025
7 checks passed
@Christopher-Chianelli
Copy link
Contributor

Thanks for your contribution @PatrickDiallo23!

@PatrickDiallo23 PatrickDiallo23 deleted the sports-league-scheduling-python-example branch January 17, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christopher-Chianelli Christopher-Chianelli Christopher-Chianelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PatrickDiallo23 @triceo @Christopher-Chianelli