-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding a enterprise profile to all modules #476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 18, 2024
zepfred
force-pushed
the
enterprise-profile
branch
from
June 18, 2024 22:49
64230e0
to
f6ad52c
Compare
triceo
requested changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text needs improvements.
Also - did you consider making similar adjustments to the Python quickstarts as well?
triceo
reviewed
Jun 19, 2024
triceo
reviewed
Jun 20, 2024
triceo
reviewed
Jun 20, 2024
triceo
reviewed
Jun 20, 2024
zepfred
force-pushed
the
enterprise-profile
branch
from
June 20, 2024 10:59
e29a585
to
d5388fc
Compare
triceo
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This pull request adds an enterprise profile to all Java modules and includes the Nearby Selection configuration in the VRP module.
Some minor changes have been included regarding the nomenclature of the test methods, and a new integration test for enterprise native mode is now part of the CI pipeline.
Checklist
Development
Code Review