Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding a enterprise profile to all modules #476

Merged
merged 12 commits into from
Jun 20, 2024

Conversation

zepfred
Copy link
Contributor

@zepfred zepfred commented Jun 18, 2024

Description of the change

This pull request adds an enterprise profile to all Java modules and includes the Nearby Selection configuration in the VRP module.

Some minor changes have been included regarding the nomenclature of the test methods, and a new integration test for enterprise native mode is now part of the CI pipeline.

Checklist

Development

  • The changes have been covered with tests, if necessary.
  • You have a green build, with the exception of the flaky tests.
  • UI and JS files are fully tested, the user interface works for all modules affected by your changes (e.g., solve and analyze buttons).
  • The network calls work for all modules affected by your changes (e.g., solving a problem).
  • The console messages are validated for all modules affected by your changes.

Code Review

  • This pull request includes an explanatory title and description.
  • The GitHub issue is linked.
  • At least one other engineer has approved the changes.
  • After PR is merged, inform the reporter.

Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text needs improvements.

Also - did you consider making similar adjustments to the Python quickstarts as well?

java/bed-allocation/README.adoc Outdated Show resolved Hide resolved
java/bed-allocation/README.adoc Outdated Show resolved Hide resolved
java/bed-allocation/README.adoc Outdated Show resolved Hide resolved
@zepfred zepfred force-pushed the enterprise-profile branch from e29a585 to d5388fc Compare June 20, 2024 10:59
@zepfred zepfred requested a review from triceo June 20, 2024 11:00
@triceo triceo merged commit e9127c3 into TimefoldAI:development Jun 20, 2024
36 checks passed
@zepfred zepfred deleted the enterprise-profile branch June 20, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't start test methods with test Maven profile enterprise Nearby selection for VRP quickstart
2 participants