Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VNCSConnectionST: Release mouse button(s) on close #1717

Merged

Commits on Jan 15, 2024

  1. VNCSConnectionST: Release mouse button(s) on close

    When the connection is severed, release all mouse buttons.
    
    This fixes an issue with x0vncserver where the local display
    would stop responding to mouse events if the connection closes
    while the remote user was holding down a mouse button.
    
    To reproduce, start a VNC client, press and hold a mouse button
    and then kill the connection (e.g. close client, kill server,
    yank network cable). This caused the local screen to no longer
    respond to any mouse-down events until a VNC client reconnects
    and clicks anywhere.
    
    This may inject a "mouse release" event while closing, however,
    if you click on your screen and then yank the mouse cable, a mouse
    release event also would not come unexpectedly, so the cure's
    side effects aren't as bad as the disease.
    
    Signed-off-by: Mike Looijmans <[email protected]>
    MikeLooijmans committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    986280b View commit details
    Browse the repository at this point in the history