Add Valgrind plugin #974
Open
Add Valgrind plugin #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the Valgrind plugin to Ceedling. The plugin implementation closely follows the Gcov plugin. Signed-off-by: James Raphael Tiovalen <[email protected]>
|
Hi @jamestiotio Thanks for reopening the PR. I promise we weren't ignoring your work. The last release was already behind schedule and we didn't want to add another major feature which would require further testing. We're really excited about your plugin and are looking forward to merging it soon. :) |
|
Sure @mvandervoord, no worries! Thank you for explaining the rationale for closing the previous PR. I'm looking forward to getting this PR merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the second attempt at adding the Valgrind plugin to Ceedling. The plugin implementation closely follows the Gcov plugin.
The
test/ceedling_0_32_rcbranch was deleted and v1.0.0 was released without these changes. I assume these changes were missed during the merging of the various v1.0.0 changes into the master branch. No changes were made from the previous PR (#807).Fixes #277.