-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : add sage package #397
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably this one change and we should be good to go, to run the pipeline
sources/install/package_crypto.sh
Outdated
@@ -40,6 +40,14 @@ function install_rsacracker() { | |||
add-to-list "RsaCracker,https://github.com/skyf0l/RsaCracker,Powerful RSA cracker for CTFs. Supports RSA - X509 - OPENSSH in PEM and DER formats." | |||
} | |||
|
|||
function install_sage { | |||
colorecho "Installing Sage" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'll need to add a CCC exclusion here as per https://exegol.readthedocs.io/en/latest/community/contributors.html#function-structure
For add-aliases
sources/install/package_crypto.sh
Outdated
function install_sage { | ||
# CODE-CHECK-WHITELIST=add-aliases | ||
colorecho "Installing Sage" | ||
fapt sagemath | ||
add-history sage | ||
add-test-command "sage --help" | ||
add-to-list "sage,https://www.sagemath.org,SageMath is a free open-source mathematics software system licensed under the GPL." | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move your installation in a install_crypto_apt_tools
function ? It's faster for builds when there are other tools via apt.
Like this one : https://github.com/ThePorgs/Exegol-images/blob/dev/sources/install/package_ad.sh#L6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch to draft. You can reopen it when you've made the changes ! |
|
||
fapt sagemath | ||
|
||
add-history sage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add history commands please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the line 12, i see add-history sage
, so it's good, no ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you add : add-history, you need to create a file containing history commands.
example : https://github.com/ThePorgs/Exegol-images/blob/main/sources/assets/shells/history.d/azure-cli
What do you think of this tool in terms of its usefulness in exegol ? |
SageMath is a widely used tool for cryptography in CTFs, but it can be tedious to install. Therefore, having a stable and functional version in Exegol would be great. Even if it means creating an image specifically for cryptography, I’m not sure. |
Ok go for me, I'm waiting for Shutdown's review |
@LighTend3r why do you say it's tedious to install? it seems to me it's as simple as |
It will be huge... I found 5-10GB on the internet |
Description
I have added the SageMath package to the crypto module of Exegol. This inclusion enables advanced mathematical computations, particularly useful for tasks such as elliptic curve cryptography, number theory, and other cryptographic algorithms.