Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : add sage package #397

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

LighTend3r
Copy link

Description

I have added the SageMath package to the crypto module of Exegol. This inclusion enables advanced mathematical computations, particularly useful for tasks such as elliptic curve cryptography, number theory, and other cryptographic algorithms.

Copy link
Member

@ShutdownRepo ShutdownRepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this one change and we should be good to go, to run the pipeline

@@ -40,6 +40,14 @@ function install_rsacracker() {
add-to-list "RsaCracker,https://github.com/skyf0l/RsaCracker,Powerful RSA cracker for CTFs. Supports RSA - X509 - OPENSSH in PEM and DER formats."
}

function install_sage {
colorecho "Installing Sage"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need to add a CCC exclusion here as per https://exegol.readthedocs.io/en/latest/community/contributors.html#function-structure
image
For add-aliases

@ShutdownRepo ShutdownRepo added waiting for additional changes new tool(s) This adds one or multiple tools to Exegol labels Oct 10, 2024
Comment on lines 43 to 51
function install_sage {
# CODE-CHECK-WHITELIST=add-aliases
colorecho "Installing Sage"
fapt sagemath
add-history sage
add-test-command "sage --help"
add-to-list "sage,https://www.sagemath.org,SageMath is a free open-source mathematics software system licensed under the GPL."
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move your installation in a install_crypto_apt_tools function ? It's faster for builds when there are other tools via apt.

Like this one : https://github.com/ThePorgs/Exegol-images/blob/dev/sources/install/package_ad.sh#L6

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qu35t-code qu35t-code self-assigned this Oct 18, 2024
@qu35t-code qu35t-code marked this pull request as draft October 28, 2024 16:42
@qu35t-code
Copy link
Member

@LighTend3r,

Switch to draft. You can reopen it when you've made the changes !

@LighTend3r LighTend3r marked this pull request as ready for review November 1, 2024 14:05
@qu35t-code qu35t-code self-requested a review November 6, 2024 21:17

fapt sagemath

add-history sage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add history commands please.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the line 12, i see add-history sage, so it's good, no ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add : add-history, you need to create a file containing history commands.

example : https://github.com/ThePorgs/Exegol-images/blob/main/sources/assets/shells/history.d/azure-cli

@qu35t-code
Copy link
Member

qu35t-code commented Nov 7, 2024

@ShutdownRepo,

What do you think of this tool in terms of its usefulness in exegol ?
He has a lot of dependencies and has big size.

@qu35t-code qu35t-code added the on hold Item on hold. Requires another matter to be resolved first. label Nov 7, 2024
@LighTend3r
Copy link
Author

SageMath is a widely used tool for cryptography in CTFs, but it can be tedious to install. Therefore, having a stable and functional version in Exegol would be great. Even if it means creating an image specifically for cryptography, I’m not sure.

@qu35t-code
Copy link
Member

Ok go for me, I'm waiting for Shutdown's review

@qu35t-code qu35t-code removed the on hold Item on hold. Requires another matter to be resolved first. label Nov 8, 2024
@qu35t-code qu35t-code added the waiting for fix Waiting for the fix to be added on exegol label Nov 8, 2024
@ShutdownRepo
Copy link
Member

@LighTend3r why do you say it's tedious to install? it seems to me it's as simple as apt install sagemath
also, any idea how heavy it it?

@LighTend3r
Copy link
Author

It will be huge... I found 5-10GB on the internet
I just remember one time when I wanted to install it and it was quite complicated, but it may have improved in the meantime.
Also, sage is on Linux, I've never managed to install it on Windows (maybe my fault). So it'd be cool if you didn't necessarily need to have a Linux system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new tool(s) This adds one or multiple tools to Exegol waiting for fix Waiting for the fix to be added on exegol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants