Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useful aliases and a FAQ for Responder #67

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

VincentSan
Copy link

Hi 👋,

I have added aliases from PR #388. In the FAQ, I added the issue reported by V3locidad on Discord, where Responder only receives NBT packets on macOS.

Copy link
Member

@Dramelac Dramelac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello
Thank you for the PR ! Just one comment, I think this info should be in the troubleshooting file not the FAQ one

@VincentSan
Copy link
Author

Hi !

I have made the necessary correction.

Copy link
Member

@ShutdownRepo ShutdownRepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR
Looks good to me, BUT as I was making sure the alias was effectively in Exegol I noticed it probably isn't. The alias is there but the networkIP aliases file is never called. In my opinion we should move the content of the networkIP file in the aliases.d/_init to fix
Once it's fixed, we'll merge the PR here
Sorry for the mess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants