Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handle jest v27 fake timers (issue #30) #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wilsonpage
Copy link

The existing check for jest fake timers no longer works as jest v27 mutates the setTimeout global differently. This patch checks for both the old and new formats.

The existing check for jest fake timers no longer works as jest v27 mutates the `setTimeout` global differently. This patch checks for both the old and new formats.
@lgandecki
Copy link
Member

Thanks, do you think this works too? #37

I like that it also upgrades the jest so the tests verify the change

@wilsonpage
Copy link
Author

Thanks, do you think this works too? #37

I like that it also upgrades the jest so the tests verify the change

👍 Looks like a better PR. You should merge that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants