support for min consecutive passes #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neezurft
force-pushed
the
retest-to-avoid-false-positives
branch
from
47326fc to
241a52e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys! here is a PR for you to consider.
I was inspired by an issue I encountered at work while using this library. It has been really useful to me otherwise, but I found in our large codebase some tests that were non-deterministic and flaky. waitForExpect would give us false positives in those cases because it will retry them until they pass. To solve this, I added an opt-in constrain (defaults to current behaviour for backwards compatibility). The idea is that a test will have to pass a number of consecutive times before it actually passes.
I added a simple test to account for this scenario I am describing.