Feature: Add Ruff GitHub Workflow #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some docs for this? |
luarss
reviewed
Jun 22, 2024
Closed
vvbandeira
reviewed
Jul 6, 2024
There was a problem hiding this comment.
I am just commenting on the GH workflow. In the future, keep PRs single-focused, either CI-related or related to code format or code changes. Also, let me know if GHA VMs meet the required HW resources or when you would like to set up an automatic deployment of the front/backend. This will require some dev time from me, so let me know in advance so I can plan accordingly.
luarss
force-pushed
the
feature/add-ruff-github-workflow
branch
from
858cce5
to
ef4d19b
Compare
|
@vvbandeira Understood, it's just that this is the very first addition of the CI, so it warrants some code/requirement changes. |
Merged
vvbandeira
previously approved these changes
Jul 9, 2024
Signed-off-by: error9098x <[email protected]>
Signed-off-by: error9098x <[email protected]>
Signed-off-by: error9098x <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Song Luar <[email protected]>
luarss
force-pushed
the
feature/add-ruff-github-workflow
branch
from
18c5940
to
72ea26c
Compare
Signed-off-by: Song Luar <[email protected]>
vvbandeira
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features: