Skip to content
This repository has been archived by the owner on Jun 13, 2022. It is now read-only.

#29 - [IMPROVEMENT] - Made code tabs in fusion resizable #36

Closed
wants to merge 2 commits into from

Conversation

Suniti13
Copy link

@Suniti13 Suniti13 commented Oct 4, 2020

Your PR should be for a corresponding issue. If the issue doesn't exist yet, create that issue and mention the issue in your PR.

Add one of the following prefixes for your PR:

[ [ISSUE-LABEL] - FEATURE ]
[ [ISSUE-LABEL] - FIX ]
[ [ISSUE-LABEL] - IMPROVEMENT ]

Your PR should contain a description of the changes you made.
The description should be within 250 words. Please try to follow this word limit.

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

Am I familiar with the tech stack of this project? (Important for PRs that have code changes)

  • Yes
  • [] No.

If yes, please mention the back-end framework used in this project. - {Django}

Have I contributed before to DomeCode? (req.)

  • Yes, once.
  • Yes, more than once but not a lot.
  • Yes, extensively.
  • No.

Have I used DomeCode? (req.)

  • Not a lot.
  • Extensively.
  • Nope.

I made style changes so that the code tabs in fusion can be resized.
They can be resized by dragging the boxes from bottom right corner.
#29

@Suniti13 Suniti13 requested a review from arthtyagi as a code owner October 4, 2020 15:46
@karx1
Copy link
Member

karx1 commented Oct 4, 2020

Please make your issue be something like #3 - Improvement instead of just improvement.

@karx1
Copy link
Member

karx1 commented Oct 4, 2020

Also, shouldn't it be resize: both; so we can resize horizontally as well as vertically? Currently your code makes it only resizable vertically. Otherwise, great work!

@Suniti13 Suniti13 changed the title [IMPROVEMENT] - Made code tabs in fusion resizable #29 - [IMPROVEMENT] - Made code tabs in fusion resizable Oct 4, 2020
@Suniti13
Copy link
Author

Suniti13 commented Oct 4, 2020

I don't think resizing horizontally would be nice here because when width is reduced just white space remains. If the width is increased, it goes beyond the left container and gets over the right container, hiding the content on the right. In both cases it doesn't look nice. If you still want me to make it resize both vertically and horizontally, I will gladly do so.

@karx1
Copy link
Member

karx1 commented Oct 4, 2020 via email

@Suniti13
Copy link
Author

Suniti13 commented Oct 4, 2020

That helped. Thanks. I will update it.

@arthtyagi
Copy link
Member

It works. However, only partially. The tabs on the left ( the ones with code are resizeable ) but it's clearly not obvious where to drag them from anymore once they are dragged from the bottom right.
I tried resizing them, worked for the first time. But then there was whitespace below the JavaScript code tab that remained until the page was refreshed.

Also, I'm able to resize the unwanted tab by dragging from the middle of the bottom tab.

image
The whitespace below JSCode doesn't go away. And upon dragging from the middle ( a bit to the right tho ) of CSS Code, the HTML code gets resized instead.

And sometimes this happens :

Screen Recording 2020-10-04 at 10.25.09 PM.zip

@karx1
Copy link
Member

karx1 commented Oct 9, 2020

@Suniti13 any updates?

@arthtyagi
Copy link
Member

Well, there hasn't been any update from the author @Suniti13 so I'm closing this ultimately.

@arthtyagi arthtyagi closed this Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants