feat(alert): optimize collapse behavior #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miownag
requested review from
honkinglin,
uyarn,
carolin913,
HaixingOoO,
NWYLZW and
ZWkang
as code owners
|
|
When message's length is less than maxLine prop, it will not show the collapse button. Optimize message not collapse test
miownag
force-pushed
the
feat/alert/collapse-opt
branch
from
8e710d1 to
3eb3029
Compare
HaixingOoO
approved these changes
Dec 17, 2024
uyarn
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When message's length is less than maxLine prop, it will not show the collapse button.
🤔 这个 PR 的性质是？
🔗 相关 Issue
暂无
💡 需求背景和解决方案
优化：当maxLine数量 < 传入的message数量时，即具备折叠条件时，才显示折叠按钮“
（注：图中示例的 maxLine 改为了 5）
📝 更新日志
feat(Alert): 在 maxLine >= message 数组长度时，不再展示【展开更多/收起】按钮
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单