Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Guide): support guide component #1581

Merged
merged 14 commits into from
Nov 7, 2022
Merged

feat(Guide): support guide component #1581

merged 14 commits into from
Nov 7, 2022

Conversation

Yilun-Sun
Copy link
Contributor

@Yilun-Sun Yilun-Sun commented Oct 10, 2022 •
edited
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

related issue: #1281

💡 需求背景和解决方案

📝 更新日志

  • feat(Guide): support guide component

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2022 •
edited
Loading

完成

@Yilun-Sun Yilun-Sun force-pushed the syl/feat-support-guide branch from b5ed483 to d9421cb Compare October 12, 2022 11:15
@xiaosansiji xiaosansiji mentioned this pull request Oct 14, 2022
Closed
3 tasks
@Yilun-Sun Yilun-Sun force-pushed the syl/feat-support-guide branch from 3a2eedd to 2c8c013 Compare October 25, 2022 15:05
@Yilun-Sun Yilun-Sun requested review from honkinglin and removed request for carolin913 and uyarn October 26, 2022 02:12
@Yilun-Sun Yilun-Sun force-pushed the syl/feat-support-guide branch from 54f0a61 to 627ea9a Compare October 26, 2022 02:37
honkinglin
honkinglin reviewed Oct 27, 2022
View reviewed changes
src/guide/_example/custom-popup.jsx Outdated Show resolved Hide resolved
src/guide/_example/dialog.jsx Outdated Show resolved Hide resolved
src/guide/_example/my-popup.jsx Outdated Show resolved Hide resolved
src/guide/_example/popup-dialog.jsx Outdated Show resolved Hide resolved
@Yilun-Sun Yilun-Sun force-pushed the syl/feat-support-guide branch from 02a961f to c838e94 Compare November 7, 2022 08:06
@Yilun-Sun Yilun-Sun requested a review from honkinglin November 7, 2022 10:27
honkinglin
honkinglin reviewed Nov 7, 2022
View reviewed changes
src/guide/utils/useMount.ts Outdated Show resolved Hide resolved
src/guide/utils/useMount.ts Outdated Show resolved Hide resolved
@honkinglin honkinglin merged commit dd606d7 into Tencent:develop Nov 7, 2022
@github-actions github-actions bot mentioned this pull request Nov 7, 2022
Merged
16 tasks
@Yilun-Sun Yilun-Sun deleted the syl/feat-support-guide branch November 8, 2022 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honkinglin honkinglin honkinglin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yilun-Sun @honkinglin