Update tgfx to the latest version. #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hparty
requested review from
kevingpqi123,
domchen and
shlzxjp
as code owners
Hparty
changed the title
# Conflicts: # src/rendering/filters/layerstyle/EffectFilter.cpp
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2612 +/- ##
=======================================
Coverage 77.38% 77.38%
=======================================
Files 420 420
Lines 22450 22450
Branches 6295 6355 +60
=======================================
Hits 17372 17372
+ Misses 3817 3815 -2
- Partials 1261 1263 +2 ☔ View full report in Codecov by Sentry. |
domchen
reviewed
Dec 6, 2024
web/src/utils/buffer.ts
Outdated
There was a problem hiding this comment.
参考一下tgfx的写法，已经不需要这个类了。这个类会多拷贝一次。
domchen
reviewed
Dec 6, 2024
CMakeLists.txt
Outdated
| @@ -493,10 +500,10 @@ if (WEB) | |||
| -sMODULARIZE=1 -sENVIRONMENT='web,worker' -sEXPORT_ES6=1 -sUSE_ES6_IMPORT_META=0) | |||
| if (CMAKE_BUILD_TYPE STREQUAL "Debug") | |||
| list(APPEND PAG_COMPILE_OPTIONS -O0 -g3) | |||
| list(APPEND PAG_LINK_OPTIONS -O0 -g3 -sSAFE_HEAP=1 -Wno-limited-postlink-optimizations) | |||
| list(APPEND PAG_LINK_OPTIONS -O0 -g3 -sSAFE_HEAP=1 -Wno-limited-postlink-optimizations -s EXPORTED_FUNCTIONS=['_malloc','_free']) | |||
There was a problem hiding this comment.
不需要增加这个接口导出，后面的buffer.ts也不需要
domchen
reviewed
Dec 6, 2024
| @@ -31,6 +31,26 @@ | |||
| using namespace emscripten; | |||
|
|
|||
| namespace pag { | |||
|
|
|||
| std::unique_ptr<ByteData> CopyDataFromUint8Array(const val& emscriptenData) { | |||
There was a problem hiding this comment.
从js拷贝内存到c++都统一用这个方法就行，不需要后面的buffer.ts
domchen
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.