Support CMake. #22
Open
Support CMake. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
reviewed
Nov 6, 2024
| set(BUILDSHARE ) | ||
| endif() | ||
|
|
||
| add_library(sheenbidi ${BUILDSHARE} ${SRC_FILES}) |
There was a problem hiding this comment.
This is highly unusual for CMake. Whether libraries are built as shared is controlled by the built-in BUILD_SHARED_LIBS CMake option. There is no need for and there shouldn't be such an option.
|
I've sent an alternative PR that uses a more modern CMake approach (target-based). #27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, it can be compiled with CMake.