Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add q4 2024 sponsors #452

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Add q4 2024 sponsors #452

wants to merge 7 commits into from

Conversation

MaggieFero
Copy link
Collaborator

Add Dalvin Digital and Galaxy Brain to our Sponsor logos list in recognition of their Q4 sponsorships.

Add Dalvin Digital Design logo
Add GB logo for the sponsor page
Added Dalvin Digital Design to our logos list
Added Galaxy Brain logo on the sponsors page
Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
techtonica-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 9:21pm

@MaggieFero
Copy link
Collaborator Author

For the review here, I'm mostly looking for whether this positioning is okay, or if I should handle the logo ordering differently in some way.

@daaimah123
Copy link
Collaborator

daaimah123 commented Jan 2, 2025

Is Dalvin's logo intentionally provided with the large white space to its right? As is seems to be creating some odd placement that I think could easily be remedied with a more square provided image.

Screenshot 2025-01-02 at 1 07 29 AM Screenshot 2025-01-02 at 1 07 37 AM

Current Branch Styling

Screenshot 2025-01-02 at 1 12 32 AM Screenshot 2025-01-02 at 1 12 27 AM

I adjusted the style sizing with a newly created fifteen-percent-width class for a better "fit" alongside other sponsor logos in bdbe1ec?

Screenshot 2025-01-02 at 1 12 00 AM Screenshot 2025-01-02 at 1 11 45 AM

@MaggieFero
Copy link
Collaborator Author

Actually that white space is that I didn't realize this white wordmark had a transparent background because I'm using dark mode 🙃 I'll ask Dalvin for a revised logo version for white backgrounds.

@MaggieFero
Copy link
Collaborator Author

The fifteen-percent-width class looks good, though!

Removing version of Dalvin Digital Design logo meant for use on dark backgrounds, because our sponsor logos are displayed on white.
Uploading a version of Dalvin Digital Design's logo meant for use on light backgrounds, like our Sponsor page
@MaggieFero
Copy link
Collaborator Author

Swapped the D3 logo with a version meant for light backgrounds!

@MaggieFero MaggieFero marked this pull request as ready for review January 2, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants