Quote randomNumber column in PostgreSQL schema
#9509
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [test specs][] say that the `World` table has an `id` column and `randomNumber` column (note the camelCasing). Indeed, the [PostgreSQL schema][] uses `randomNumber` in its `CREATE TABLE` statement. However, the `CREATE TABLE` statement does not quote the column name, so PostgreSQL treats the name as if it were lowercase. Also note that the PostgreSQL schema has `CREATE TABLE World` _and_ `CREATE TABLE "World"` statements. Presumably, this is because the former actually creates a `world` table because it too is not quoted. (Whereas the latter actually creates a `World` table.) This commit modifies the `CREATE TABLE "World"` statement to quote the `randomNumber` column so that its camel case is preserved. [test specs]: https://github.com/TechEmpower/FrameworkBenchmarks/wiki/Project-Information-Framework-Tests-Overview [PostgreSQL schema]: https://github.com/TechEmpower/FrameworkBenchmarks/blob/ddd09520c10926c0e2c73a005b1f79f5a68142a8/toolset/databases/postgres/create-postgres.sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've opened this PR because it is a point of frustration when implementing tests for new frameworks, but I've marked it as draft because the change may be too breaking.
The test specs say that the
Worldtable has anidcolumn andrandomNumbercolumn (note the camelCasing). Indeed, the PostgreSQL schema usesrandomNumberin itsCREATE TABLEstatement. However, theCREATE TABLEstatement does not quote the column name, so PostgreSQL treats the name as if it were lowercase.Also note that the PostgreSQL schema has
CREATE TABLE WorldandCREATE TABLE "World"statements. Presumably, this is because the former actually creates aworldtable because it too is not quoted. (Whereas the latter actually creates aWorldtable.)This commit modifies the
CREATE TABLE "World"statement to quote therandomNumbercolumn so that its camel case is preserved.