Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPEN_DOCUMENT and CREATE_DOCUMENT intents support #3953

Draft
wants to merge 2 commits into
base: release/4.0
Choose a base branch
from

Conversation

TranceLove
Copy link
Collaborator

Extra information

It is assumed that the file selected/ to be saved are on the Android device locally. Haven't tested if user attempts to pick the file at remote location - or even not able to test at all - so beware.

Issue tracker

Fixes #3932

Automatic tests

  • Added test cases

Manual tests

  • Done

  • Device: Pixel 2 emulator

  • OS: Android 9

  1. Install KeePassDX
  2. Install build including this changeset
  3. Open KeePassDX
  4. Tap Create Database
  5. DocumentsUI and Amaze should show up as choice for handling the action
  6. Use Amaze to handle the action. Just Once or Always both are OK
  7. Choose the destination folder where the new database file should be stored
  8. Tap Save at the Snack Bar, file dialog should popup with keepass.kbdx filled in
  9. Save as-is or enter a new filename, best end with .kbdx
  10. Amaze should close and back to KeePassDX, fill in the details as usual
  11. Close Amaze and KeePassDX
  12. Reopen KeePassDX, tap Open Existing Database
  13. DocumentsUI and Amaze should show up as choice for handling the action
  14. Use Amaze to handle the action. Just Once or Always both are OK
  15. Choose the database created at 9 by browsing to the folder where the file is located
  16. Amaze should close and back to KeePassDX, fill in the credentials to unlock database
  17. The database should open properly

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

Allows external programs use Amaze to open files with OPEN_DOCUMENT intent.

Addresses TeamAmaze#3932
@TranceLove
Copy link
Collaborator Author

This PR is not targeting 4.0 release, hence drafting status.

Also, pending tasks

  • hide the FAB

@TranceLove TranceLove requested review from VishalNehra, EmmanuelMess and VishnuSanal and removed request for VishalNehra and EmmanuelMess October 14, 2023 15:51
@VishnuSanal
Copy link
Member

will this fix #3634 too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for basic API calls like ACTION_OPEN_DOCUMENT
2 participants