Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed playback on Windows with block=false #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed playback on Windows with block=false #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion playsound.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import logging
logger = logging.getLogger(__name__)

_openedSoundsWin = []

class PlaysoundException(Exception):
pass

Expand Down Expand Up @@ -52,12 +54,20 @@ def winCommand(*command):

try:
logger.debug('Starting')
if (sound in _openedSoundsWin):
winCommand(u'close {}'.format(sound))
_openedSoundsWin.remove(sound)
winCommand(u'open {}'.format(sound))
winCommand(u'play {}{}'.format(sound, ' wait' if block else ''))
if not block:
_openedSoundsWin.append(sound)
logger.debug('Returning')
finally:
try:
winCommand(u'close {}'.format(sound))
if (block):
winCommand(u'close {}'.format(sound))
else:
pass
except PlaysoundException:
logger.warning(u'Failed to close the file: {}'.format(sound))
# If it fails, there's nothing more that can be done...
Expand Down