Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trying to fix POST method #8

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

trying to fix POST method #8

wants to merge 4 commits into from

Commits on Mar 3, 2023

  1. fix mergeRequestInits 

    - mergeRequestInits basically only returns empty object 🤷
    @JLarky
    JLarky committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    1a989cd View commit details
    Browse the repository at this point in the history

  2. do not send body for GET

    @JLarky
    JLarky committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    ead0f3b View commit details
    Browse the repository at this point in the history

  3. use for in instead of Object.assign 

    - new Request satisfies RequestInit but you can't easily iterate over it
- https://stackoverflow.com/a/75623336/74167
    @JLarky
    JLarky committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    e9209fc View commit details
    Browse the repository at this point in the history

  4. use the same approach in mergeFetchOpts 

    - I haven't tested that
    @JLarky
    JLarky committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    386241e View commit details
    Browse the repository at this point in the history