Removing a pin to Sui version, using always latest instead #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inned Sui version of testnet soon results in an error. We use the latest Sui tag instead to avoid this.
|
Should we also update Line 8 in 6a20507 |
I believe I kept it on this version because that was the version of the protochain compiler. I wanted to make sure not to use any newer APIs. However, given that the contract is now "sealed", we could change the version. At the moment I don't see the benefit of doing that though, because we won't be at the same version as running examples anyway. |
loverdos
approved these changes
Oct 10, 2024
tuky191
pushed a commit
that referenced
this pull request
Nov 6, 2024
Because Suibase does not support pagination of Github releases, any pinned Sui version of testnet soon results in an error. We use the latest Sui tag instead to avoid this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Suibase does not support pagination of Github releases, any pinned Sui version of testnet soon results in an error. We use the latest Sui tag instead to avoid this.