Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: standard circom tests #47

Merged
merged 7 commits into from
Jun 6, 2024
Merged

test: standard circom tests #47

merged 7 commits into from
Jun 6, 2024

Conversation

florin5f
Copy link
Contributor

@florin5f florin5f commented Jun 3, 2024

No description provided.

@florin5f florin5f requested a review from dkales June 3, 2024 16:19
@dkales
Copy link
Contributor

dkales commented Jun 3, 2024

You should probably configure your editor to autoformat using rustfmt, the CI catches this.
(if you use rust-analyzer in vscode just enable format on save in settings)

@dkales
Copy link
Contributor

dkales commented Jun 3, 2024

Some discussion points (probably leave open until @fnieddu is back):

  • can we import circom stdlib from upstream (e.g., as a submodule) instead of shipping it here
  • make generic enough to also easily work with MPC assignment

Copy link
Contributor

@dkales dkales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing to look into: should these all be run on every testrun/ci?
If we want this then we probably have to compile them with optimizations.
Or should we have some external integration test binary that does all this and is only run on demand?

@florin5f florin5f force-pushed the feat/compiler_tests branch from c5568b4 to 2b50b4a Compare June 6, 2024 10:38
@dkales dkales merged commit d396ca6 into main Jun 6, 2024
5 of 6 checks passed
@dkales dkales deleted the feat/compiler_tests branch June 13, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants