Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Use shared TypoScript lib for headless pages #651

Merged
merged 6 commits into from
Sep 15, 2023
Merged

[FEATURE] Use shared TypoScript lib for headless pages #651

merged 6 commits into from
Sep 15, 2023

Conversation

schloram
Copy link
Contributor

This way we reduce code duplications and make it easier to add new headless pages (typeNums).

@coveralls
Copy link

coveralls commented Sep 14, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6194795917

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.756%
Totals Coverage Status
Change from base Build 6173629096: 0.0%
Covered Lines: 797
Relevant Lines: 1270
💛 - Coveralls

twoldanski
twoldanski requested changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@twoldanski twoldanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you make linter happy please, so we can merge it?

@schloram
Copy link
Contributor Author

Nice! Can you make linter happy please, so we can merge it?

Fixed it second try :D

@lukaszuznanski lukaszuznanski added the enhancement New feature or request label Sep 15, 2023
@lukaszuznanski lukaszuznanski merged commit c446257 into TYPO3-Headless:master Sep 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoldanski twoldanski twoldanski approved these changes

@lukaszuznanski lukaszuznanski lukaszuznanski approved these changes

Assignees

@schloram schloram

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schloram @coveralls @lukaszuznanski @twoldanski