Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Improve redirect handling #638

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

twoldanski
Copy link
Collaborator

Replace default SiteBaseRedirectResolver
with headless' one in order to handle proper redirects with headless approach.

  • fix tests
  • fix CS

@coveralls
Copy link

coveralls commented Aug 25, 2023

Pull Request Test Coverage Report for Build 6022819070

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 62.697%

Totals Coverage Status
Change from base Build 6022187015: 0.6%
Covered Lines: 795
Relevant Lines: 1268

💛 - Coveralls

@twoldanski twoldanski force-pushed the task/improve-redirect-handling branch from 3f60c7f to 1c90218 Compare August 25, 2023 14:40
Classes/Middleware/SiteBaseRedirectResolver.php Outdated Show resolved Hide resolved
Tests/Functional/BaseTest.php Outdated Show resolved Hide resolved
Tests/Unit/ContentObject/IntegerContentObjectTest.php Outdated Show resolved Hide resolved
Replace default SiteBaseRedirectResolver
with headless' one in order to handle proper redirects with headless approach.
@twoldanski twoldanski force-pushed the task/improve-redirect-handling branch from a96773b to 188931c Compare August 30, 2023 09:03
@lukaszuznanski lukaszuznanski merged commit 62c7700 into master Aug 30, 2023
7 checks passed
@lukaszuznanski lukaszuznanski deleted the task/improve-redirect-handling branch August 30, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants