Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SettingUpTypo3Ddev.rst #353

Merged
merged 3 commits into from
Aug 3, 2024
Merged

Conversation

mtness
Copy link
Contributor

@mtness mtness commented Aug 2, 2024

Since we are on the page "Setting up TYPO3 WITH DDEV" it is misleading to not see the ddev commands directly in the tab container, so I changed the tab ordering so that the user sees the ddev command first.

Best Regards, MT

Since we are on the page "Setting up TYPO3 WITH DDEV"
it is misleading to not see the ddev commands directly in the tab container, so I changed the tab ordering so that the user sees the ddev command first.

Best Regards, MT
garvinhicking
garvinhicking previously approved these changes Aug 3, 2024
Copy link
Contributor

@garvinhicking garvinhicking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, that does make sense 😅

@garvinhicking
Copy link
Contributor

@linawolf could you have a look why the "group-tab" failure happens in the tests?

@linawolf
Copy link
Member

linawolf commented Aug 3, 2024

The indentation was off, fixed it

@linawolf
Copy link
Member

linawolf commented Aug 3, 2024

Thanks for your contribution! That was a good idea

@linawolf linawolf merged commit 0c30de4 into TYPO3-Documentation:main Aug 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants