Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/npm test #139

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Fix/npm test #139

merged 3 commits into from
Jan 24, 2024

Conversation

A-K-O-R-A
Copy link
Contributor

Description

NPM test script

Currently the test script is defined as npm run lint && npm run useChrome && npm run build. Every time a developer will run npm run test they will automatically also run npm run useChrome. On linux this will override the existing manifest.json therefore making it extremely annoying to keep the Firefox manifest. This should not be the default behavior for a test.
I also changed the workflow from implicitly using the chrome manifest through the npm run test command to explicitly using the chrome config.

Typescript

I created the PR because this projects uses typescript but those typescript files never actually get checked. For example the file src/contentScripts/other/hisqis/newTable.ts will throw a error on Line 113 if you run tsc.
With this PR every time the test script gets run it will additionally do a typescript check through the tsc --noEmit command. This also means that the test script will fail locally and in CI when a typescript error is detected.

Type of change

  • Bug fix (non-breaking change which fixes a bug)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that might cause existing functionality to not work as expected)
  • Testing scripts

Further info

  • This change requires a documentation update
  • I updated the documentation accordingly, if required
  • I commented my code where its useful

Testing

  • Tested my changes on Firefox
  • Tested my changes on Chromium-Based-Browsers
  • Successfully run npm run test locally

@A-K-O-R-A A-K-O-R-A requested review from OliEfr and a team as code owners January 18, 2024 18:15
@OliEfr OliEfr merged commit 5bea269 into TUfast-TUD:develop Jan 24, 2024
1 check passed
@A-K-O-R-A A-K-O-R-A deleted the fix/npm-test branch January 24, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants