Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NPM test script
Currently the
test
script is defined asnpm run lint && npm run useChrome && npm run build
. Every time a developer will runnpm run test
they will automatically also runnpm run useChrome
. On linux this will override the existingmanifest.json
therefore making it extremely annoying to keep the Firefox manifest. This should not be the default behavior for a test.I also changed the workflow from implicitly using the chrome manifest through the
npm run test
command to explicitly using the chrome config.Typescript
I created the PR because this projects uses typescript but those typescript files never actually get checked. For example the file
src/contentScripts/other/hisqis/newTable.ts
will throw a error on Line 113 if you run tsc.With this PR every time the test script gets run it will additionally do a typescript check through the
tsc --noEmit
command. This also means that the test script will fail locally and in CI when a typescript error is detected.Type of change
Further info
Testing
npm run test
locally