Make notification container height fit-content instead of 50vh (fix f… #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OliEfr
deleted the
129-bug-notification-container-covers-critical-opal-interface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
I proprose the following changes in my PR:
50vhtofit-contentso the container doesn't cover the lower half of the right side of the device screen and therefore blocks the underlying OPAL interface.Referenced Issue: #129
Type of change
Further info
Testing
We have 1500+ Users. Please test your changes thoroughly.
npm run testlocally-> Not tested since the change is trivial and widely supported by browsers.