Fixing the Download button for the Model tab. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: julianbollig <[email protected]>
mschuettlerTNG
requested changes
Jan 13, 2025
| @@ -288,6 +288,8 @@ function postImageToEnhance(imageUrl: string) { | |||
|
|
|||
| function showDownloadModelConfirm(downList: DownloadModelParam[], success?: () => void, fail?: () => void) { | |||
| showDowloadDlg.value = true; | |||
| showSetting.value = false; | |||
| console.log(downList) | |||
There was a problem hiding this comment.
Do we need this? :)
There was a problem hiding this comment.
The console log of course not. Showsetting.value = false is needed because otherwise the download dialog opens behind the settings which does not look very professional (and you have to close the settings anyways in order to interact with the download dialog).
| @@ -57,7 +57,7 @@ | |||
| - | |||
| </div> | |||
| </td> | |||
| <td class="flex flex-col items-center text-sm text-green-400"> | |||
| <td class="items-center text-sm text-green-400"> | |||
There was a problem hiding this comment.
Why was the styling changed?
There was a problem hiding this comment.
because the body of the last column of the download dialog was not aligned in the middle, which looked ugly (this can be seen when having a file name, e.g. most gguf files, which extends over two lines).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.