Issue 68: Implement redirect handling. #70
Conversation
Perform redirects when receiving HTTP 301 and HTTP 302 status codes. This implements a hard-coded max redirect of 10. A custom property could be implemented but this is left for a future decision or for a reviewers input. This adds new parameters to the RestService HTTP functions for performing the redirets. The functions are all made to have the same parameters so that the redirect can pass a consistent callback. Unused parameters, such as `json` in the `get()` method, are ignored. Logging is added for redirects, when `logLevel` is set to `DEBUG` (case insensitive). An error is printed when max redirects is reached. When no redirection is requested, the `redirectRecurse()` function returns false so that the caller can continue normal behavior.
kaladay
requested review from
rmathew1011,
rhundal7,
wwelling,
Dbreck-TAMU and
jeremythuff
Make the code less redundant by adding an additional private method.
| @@ -8,14 +8,15 @@ export class RestService { | |||
| return request(req, cb); | |||
| } | |||
|
|
|||
| public get(url: string, contentType: string = 'application/json'): Promise<any> { | |||
| public get(url: string, json: any = null, contentType: string = 'application/json', accept: string | string[] = [ 'application/json', 'text/plain' ], redirectCount: number = 0): Promise<any> { | |||
There was a problem hiding this comment.
For code cleanliness, methods should have two or less arguments. Dyadic is preferred max number of arguments. Triadic is borderline messy. Four or more is in need of code cleanup.
There was a problem hiding this comment.
I would prefer a type or interface with these arguments as properties opposed to adding too many arguments.
It is hardcoded to not follow redirects on POST, PUT, etc...
Looks like we need |
|
I found problems and the |
resolves #68
Perform redirects when receiving HTTP 301 and HTTP 302 status codes. This implements a hard-coded max redirect of 10.
A custom property could be implemented but this is left for a future decision or for a reviewers input.
This adds new parameters to the RestService HTTP functions for performing the redirets. The functions are all made to have the same parameters so that the redirect can pass a consistent callback. Unused parameters, such as
jsonin theget()method, are ignored.Logging is added for redirects, when
logLevelis set toDEBUG(case insensitive). An error is printed when max redirects is reached.When no redirection is requested, the
redirectRecurse()function returns false so that the caller can continue normal behavior.