Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CMD-147 enable BlueSky share #490

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Dec 10, 2024

Overview / Changes

Enable BlueSky social media service to News share buttons.

Related

Enables feature from:

Testing

  1. Build/Start CMS on this branch.
    Deployed to dev.
  2. Create/Open a news article.
    E.g. (dev) NSF Selects TACC Supercomputers for National AI Research Resource Pilot.
  3. Verify BlueSky icon is present in share options.
  4. Click BlueSky icon.
  5. Verify new tab appears that lets user share link on BlueSky.
  6. Verify article image loads.

UI

CMS Feature Works on Dev

test.on.dev.mov

BlueSky Feature Works With Prod URL

test.prod.url.mov

@wesleyboar wesleyboar marked this pull request as ready for review December 10, 2024 16:51
Copy link
Collaborator

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wesleyboar wesleyboar merged commit 3effd67 into main Dec 10, 2024
1 check passed
@wesleyboar wesleyboar deleted the feat/CMD-147-enable-blue-sky branch December 10, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants