Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tup-715 save patch fix of subdomain link ugly URLs #468

Merged
merged 7 commits into from
Aug 13, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jun 12, 2024

Overview

Save a working snippet that reverts some Google Analytics JavaScript.

Links on CMS page to subdomain are changed by Google to be functional but full of unsightly query parameters.

Related

Changes

  • saved snippet that I have long been using to patch the bug

Testing

  1. Open tacc.utexas.edu.
  2. In menu, click "Use TACC" > "Documentation".

Verify URL does not have a string of query parameters.

  1. Open https://tacc.utexas.edu/use-tacc/getting-started/.
  2. On page, click "1. Create an Account" > [Create Account].

Verify URL does not have a string of query parameters.

To test previous behavior, comment out <script> in snippet #150, then follow steps 1 through 4.

UI

With Snippet
TUP-715.to.TAM.mov
TUP-715.to.Docs.mov
Sans Snippet
Before.TUP-715.to.Docs.mov
Before.TUP-715.to.TAM.mov

Notes

Not directly used. Just saving from:

@wesleyboar wesleyboar changed the title fix: tup-715 ugly urls for subdomain links fix: tup-715 save snippet to fix ugly urls for subdomain links Jul 10, 2024
@wesleyboar wesleyboar changed the title fix: tup-715 save snippet to fix ugly urls for subdomain links fix: tup-715 save snippet / fix ugly urls for subdomain links Jul 10, 2024
@wesleyboar wesleyboar changed the title fix: tup-715 save snippet / fix ugly urls for subdomain links fix: tup-715 save snippet / fix subdomain link ugly URLs Jul 10, 2024
@wesleyboar wesleyboar changed the title fix: tup-715 save snippet / fix subdomain link ugly URLs fix: tup-715 save snippet fix subdomain link ugly URLs Jul 10, 2024
@wesleyboar wesleyboar changed the title fix: tup-715 save snippet fix subdomain link ugly URLs fix: tup-715 save patch fix of subdomain link ugly URLs Jul 10, 2024
@wesleyboar wesleyboar requested a review from jarosenb July 24, 2024 18:36
@wesleyboar
Copy link
Member Author

wesleyboar commented Jul 24, 2024

Added "Testing" steps and "UI" (before and after videos).

@wesleyboar
Copy link
Member Author

Improved "Testing" steps.

@jarosenb jarosenb merged commit 20b334f into main Aug 13, 2024
1 check passed
@jarosenb jarosenb deleted the fix/tup-715-prevent-ugly-urls branch August 13, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants