feat: save 2 css snippets #459
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| <template id="css-banner-tacc--notes"> | ||
| <!-- TO DYNAMICALL REDUCE HEIGHT OF BANNER: NO NEED to edit this stylesheet. Edit banner "Picture / Image" on CMS. Set `style="height: 60vh; max-height: 550px; min-height: 230px;"`. To use static height, set `style="height: 550px"` instead. --> | ||
| </template> | ||
| <style id="css-banner-tacc"> | ||
| /* To limit width of title on wide screens */ | ||
| @media (width >= 992px) { | ||
|
|
@@ -23,7 +26,7 @@ | |
| left: 0; top: 0; bottom: 0; right: 0; | ||
| background-color: var(--global-color-primary--x-light); | ||
| } | ||
| .banner-cell--major a:hover :is(.u-highlight, .highlight) { | ||
|
There was a problem hiding this comment. Two class names are supported: ITCSS class name, simple class name. |
||
| background-color: var(--global-color-accent--normal); | ||
| } | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <style id="css-global-a11y"> | ||
| /* 1. To make mobile menu button stand out */ | ||
| .navbar-dark .navbar-toggler { | ||
| border-color: var(--global-color-primary--normal); | ||
| } | ||
|
|
||
| /* 2. To make keyboard focus stand out on header */ | ||
| /* | ||
| .nav-link:focus-visible, | ||
| #header-logo:focus-visible, | ||
| .navbar-dark .navbar-toggler:focus-visible { | ||
| */ | ||
|
Comment on lines
+8
to
+12
There was a problem hiding this comment. I do not know why this is commented out. When I remember, or when prodded, I will comment it or remove it accordingly. |
||
| #s-header :focus, | ||
| #header-branding a:focus, | ||
| .s-search-bar::part(input):focus, | ||
| .s-search-bar::part(button):focus { | ||
| outline-color: var(--global-color-primary--xx-light); | ||
| } | ||
| </style> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If dev is asked to change height of the banner, and sees this snippet, they may be tempted to work in here. But this stylesheet intentionally does not manage the banner height, because CMS editor should use
styletag to set image height reliably.¹Because TACC/Core-CMS clones
styleattribute of CMS image to parent tags that appear if image is made a link or given a caption.